chore: bump CMake policy max to 4.3, list core-nanobind-shared#77
Merged
Conversation
Set the upper bound of every `cmake_minimum_required(VERSION min...max)` range to 4.3 uniformly across the sample projects, and add the `core-nanobind-shared` example to the top-level README project table. Assisted-by: ClaudeCode:claude-opus-4.8
find_package(PythonExtensions) pulls in FindPythonInterp, which CMake removed in 3.27; capping the policy max below 3.27 keeps it available. Assisted-by: ClaudeCode:claude-opus-4.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Sets the upper bound of every
cmake_minimum_required(VERSION min...max)range to4.3uniformly across the sample projects (bounds previously ranged from3.19to3.30); each minimum is left unchanged. Also adds thecore-nanobind-sharedexample to the top-level README project table, which was missing since it landed after the README.